Update "upgrading" guide for Symfony5 #12673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtension (phansys) This PR was merged into the 4.4 branch. Discussion ---------- [Messenger] Update version constraint for Redis extension Update version constraint for Redis extension in order to be consistent with the check performed in the component: https://github.com/symfony/symfony/blob/625a4dbfdafcb8cea8ff90a62b9c24b28694938d/src/Symfony/Component/Messenger/Transport/RedisExt/Connection.php#L50-L52. Commits ------- edb2101 [Messenger] Update version constraint for Redis extension
Come from symfony#12633 issue
|
Hi! Thank you for working on this one. Unfortunately, two people (with very similair names!) worked on the same topic: #12671. I've decided to merge this PR and add some improvements from #12671 in it afterwards. So the result on symfony.com will be very similair to your changes :) I've also merged this in 4.4 (as it's talking about upgrading from 4.4 to 5.0, I think it makes sense to have it in 4.4). We'll take care of merging it into newer versions from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Come from #12633 issue
#SymfonyHackday